| Type | Line | Description |
|---|---|---|
| TODO | 33 | (emakarov): otherwise the construction of PaymentMethodsLibrary |
| Type | Line | Description |
|---|---|---|
| TODO | 229 | "Location" header? |
| TODO | 272 | "Location" header? |
| TODO | 342 | "Location" header? |
| Type | Line | Description |
|---|---|---|
| TODO | 33 | rework exception handling for vacation-calendar and team-assignment !!! |
| TODO | 120 | check on owner or leader rights |
| TODO | 164 | check on owner or leader rights |
| Type | Line | Description |
|---|---|---|
| TODO | 61 | this is catched by Handler.php, but I'd prefer to do this here |
| Type | Line | Description |
|---|---|---|
| TODO | 106 | ag: quick solution. Refactor later. |
| Type | Line | Description |
|---|---|---|
| TODO | 130 | ag: quick solution. Refactor later. |
| Type | Line | Description |
|---|---|---|
| TODO | 57 | mbothstedt do we also need handling for country and language versions at this point? |
| Type | Line | Description |
|---|---|---|
| TODO | 163 | ag: climate: check price via curl one more time? |
| TODO | 179 | ag: climate: should addOn be validated? |
| Type | Line | Description |
|---|---|---|
| TODO | 281 | ag: later we must receive from frontEnd arrays with textKeys and variables |
| TODO | 288 | KV - unter Absprache mit Frontend auf JSON umbauen |
| TODO | 475 | fh Replace variable for inquiry_confirmation_description |
| Type | Line | Description |
|---|---|---|
| TODO | 152 | ag check if this is used correctly. saveAddons is returning an array which is not being used here! |
| Type | Line | Description |
|---|---|---|
| TODO | 37 | change to getRequestKeys() |
| TODO | 40 | check if all required array keys are given |
| Type | Line | Description |
|---|---|---|
| TODO | 318 | at - work with exception instead of $result['error'] once downloadOrGetImageInfoDeprecated can be removed |
| Type | Line | Description |
|---|---|---|
| TODO | 251 | mbothstedt check with Freedesign team whether this id may be changed. |
| TODO | 435 | KV - switch from itemGroup to translated productAlias, add counter or include it to position name function if it is possible |
| Type | Line | Description |
|---|---|---|
| TODO | 244 | em - PHPStorm says that static function does not exist |
| TODO | 273 | em - PHPStorm says that static function does not exist |
| Type | Line | Description |
|---|---|---|
| TODO | 27 | ag: validate dates. |
| Type | Line | Description |
|---|---|---|
| TODO | 58 | I ignored this because the table where they appear doesn't exist yet. The author of the getActiveRooms function is Anabel Wehnert.the function should refactor, with model should rewrite |
| Type | Line | Description |
|---|---|---|
| TODO | 92 | handle structure with model |
| Type | Line | Description |
|---|---|---|
| TODO | 709 | make it faster |
| Type | Line | Description |
|---|---|---|
| TODO | 100 | Implement rehashPasswordIfRequired() method. |
| Type | Line | Description |
|---|---|---|
| TODO | 124 | check also type to differ between user/guest also here and set $user->actAsGuest(true/false)! |
| Type | Line | Description |
|---|---|---|
| TODO | 61 | ag: check hardcoded var context_code. |
| TODO | 62 | RR: check hardcoded var context_code. |
| Type | Line | Description |
|---|---|---|
| TODO | 53 | ag: check hardcoded var context_code. |
| TODO | 54 | RR: check hardcoded var context_code. |
| TODO | 68 | ag: nullable person first_name and last_name leads to errors - |
| TODO | 71 | RR: @author Regina Rossberg check later. |
| Type | Line | Description |
|---|---|---|
| TODO | 131 | Implement rehashPasswordIfRequired() method. |
| Type | Line | Description |
|---|---|---|
| TODO | 73 | at - This is bad style. |
| Type | Line | Description |
|---|---|---|
| TODO | 107 | HW ausbauen kommt nicht aus der sd Tabelle |
| Type | Line | Description |
|---|---|---|
| TODO | 30 | ag: climate: may be move to repo. |
| TODO | 47 | ag: climate: may be move to repo. |
| Type | Line | Description |
|---|---|---|
| TODO | 200 | ag: climate: check measure units, specialFormat, freeForm (circle form ...), number of pages. |
| TODO | 338 | ag: climate: remove later. |
| TODO | 365 | ag: climate: remove later. |
| Type | Line | Description |
|---|---|---|
| TODO | 27 | will be reworked when it's clear where to put setup stuff for backend and cms for changing environments (f.e. Partnershops etc.) |
| Type | Line | Description |
|---|---|---|
| TODO | 682 | LE: no guestlogin > no guestlogin implemented yet |
| Type | Line | Description |
|---|---|---|
| TODO | 76 | change as soon as we have any contract data |
| Type | Line | Description |
|---|---|---|
| TODO | 401 | mbothstedt find a better way - Logging? |
| TODO | 540 | mbothstedt - do we need the svg Files here or does the mockup renderer pick them up |
| TODO | 924 | MB - was sollte hier zurück gegeben werden, wenn die Condition nicht zutrifft? |
| Type | Line | Description |
|---|---|---|
| TODO | 48 | quynt: it'll be removed before make PR |
| Type | Line | Description |
|---|---|---|
| TODO | 40 | quynt: remove it later |
| Type | Line | Description |
|---|---|---|
| TODO | 469 | mbothstedt Outsource ID as constant in helper file? |
| Type | Line | Description |
|---|---|---|
| TODO | 1133 | NW / KV - set $hiddenProps as constant |
| Type | Line | Description |
|---|---|---|
| TODO | 323 | $this->log->info('order {marketplaceOrderId}: found old order that is already canceled manually, change state to {processingState}', [ |
| Type | Line | Description |
|---|---|---|
| TODO | 92 | (emakarov): see comment in AmazonOrderFetchCommand::handle() |
| Type | Line | Description |
|---|---|---|
| TODO | 467 | all - this should be migradted into the additionalData array - could be done when addOns get refactored |
| Type | Line | Description |
|---|---|---|
| TODO | 145 | (emakarov): find the way to pass general data further down the call stack so that |
| TODO | 392 | Regina: after refactoring class app/StorageObjects/BasicOrder/CustomerData.php delete phpstan-ignore-next-line from here |
| TODO | 535 | Regina: after refactoring class app/StorageObjects/BasicOrder/CustomerData.php delete phpstan-ignore-next-line from here |
| TODO | 543 | Regina: after refactoring class app/StorageObjects/BasicOrder/CustomerData.php delete phpstan-ignore-next-line from here |
| TODO | 641 | RR, AT - there needs to be a null check for person here |
| Type | Line | Description |
|---|---|---|
| TODO | 85 | az, at - $order is of wrong Type, also if it is supposed to be an OrderHeader then the variable name is bad too. |
| TODO | 152 | Azad refactor this part of code |
| Type | Line | Description |
|---|---|---|
| TODO | 459 | all - $order is of type Order and Order::positions is an array of Position. Position::quantity is an int. The comment below says otherwise. Anybody knows why? |
| TODO | 1636 | ag: move logic in separate object, use polymorphism. |
| Type | Line | Description |
|---|---|---|
| TODO | 796 | at hw - production_stop should always be an integer and not conditional a string |
| Type | Line | Description |
|---|---|---|
| TODO | 305 | Regina needs to fix this. Regina, please take care of it. You removed it from app/StorageObjects/BasicOrder/CustomerData.php , If you delete something, please make sure to check the code for any references where it is being called, and don’t forget to test it. |
| TODO | 495 | all - should be cached |
| TODO | 533 | all - should be cached |
| TODO | 561 | all - we continue here when there are no positions in the order ??? |
| TODO | 1253 | all - those are actually validations and should be done in the OrderSubmitter - here it's too late |
| TODO | 1291 | at - obtaining the ID should be cached |
| Type | Line | Description |
|---|---|---|
| TODO | 248 | KV - add item_data_generation values given by ItemMaster |
| TODO | 257 | KV - clarify whether deliveryOptions are needed in this request or separated |
| TODO | 359 | KV - compute sellingPrice with tax values and product prices |
| TODO | 360 | KV - add balanceData from Balance class |
| TODO | 405 | KV - get customerDesignId from given requestData |
| TODO | 406 | KV - check what values are needed for variants |
| Type | Line | Description |
|---|---|---|
| TODO | 63 | all - do we really only log here or should we also abort the process (throw exception)P |
| Type | Line | Description |
|---|---|---|
| TODO | 560 | LE: hier müssen noch die Bedingungen rein, was es kosten WÜRDE, wenn verschiedene Aufschläge auf der Bestellabschlussseite hinzu kämen |
| Type | Line | Description |
|---|---|---|
| TODO | 148 | BUG-8604 |
| TODO | 155 | FINANCE set invoices paid -> needed if we use paycheck for admin functions + set payment memo?!? |
| Type | Line | Description |
|---|---|---|
| TODO | 499 | at - always true ? |
| TODO | 547 | DP where to save data from saferpay - transaction code |
| Type | Line | Description |
|---|---|---|
| TODO | 459 | ag: uncomment later in order to filter by all online payment methods (see also PaymentMethod class). |
| TODO | 2201 | hwue maybe better placed in ScoreCardLibrary ? |
| Type | Line | Description |
|---|---|---|
| TODO | 33 | should have been Str::chopStart |
| Type | Line | Description |
|---|---|---|
| TODO | 591 | hwue - function intended for Norway B2C scoring over connectAPI |
| Type | Line | Description |
|---|---|---|
| TODO | 700 | UPA-8137 |
| TODO | 737 | UPA-8137 Step3 remove |
| TODO | 759 | UPA-8137 Step3 remove |
| TODO | 854 | UPA-8137 Step3 remove |
| TODO | 858 | UPA-8137 Step3 remove |
| TODO | 872 | UPA-8137 Step3 remove |
| TODO | 1020 | RR UPA-8137 Step 3 |
| TODO | 1046 | remove after migration UPA-8137 Step 3 |
| TODO | 1102 | MM delete print24_order_shipping_packages |
| TODO | 1181 | RR UPA-8137 Step 3 |
| TODO | 1627 | RR remove UPA-8137 step 5 |
| TODO | 1756 | RR remove UPA-8137 step 5 end |
| TODO | 1772 | check "mandant" => "" |
| TODO | 1786 | RR remove UPA-8137 step 5 |
| Type | Line | Description |
|---|---|---|
| TODO | 103 | all - check if that is a valid way to fix such shopping carts |
| Type | Line | Description |
|---|---|---|
| TODO | 145 | nbraeuer: revert this! currently set for price testing |
| Type | Line | Description |
|---|---|---|
| TODO | 164 | how to handle variables? |
| TODO | 241 | mbothstedt Error handling removed - Bug with empty translations and Mails if there is an error with variables. |
| Type | Line | Description |
|---|---|---|
| TODO | 26 | ag: later we must receive from frontEnd arrays with textKeys and variables |
| Type | Line | Description |
|---|---|---|
| TODO | 318 | Azad care about function getBasketHeadersByPartyId |
| Type | Line | Description |
|---|---|---|
| TODO | 343 | at - MarketplaceLibrary does not need to be instanciated here in a loop |
| TODO | 529 | KV - add process to generate thumbnail also for order without design (P24) |
| TODO | 1062 | ag: move the logic to separate class later. |
| Type | Line | Description |
|---|---|---|
| TODO | 266 | KV - merge add ons, check whether add ons exclude each other or one is no more possible |
| TODO | 284 | KV - merge payment |
| TODO | 304 | KV - merge other order data |
| TODO | 323 | at - IS THIS ALWAYS NOT EXPRESS ??? |
| Type | Line | Description |
|---|---|---|
| TODO | 245 | RR: Mdh/Global/Lib_VAT_Number/_send_request |
| Type | Line | Description |
|---|---|---|
| TODO | 187 | ag: maybe collect and set/return errors/changes array later. |
| Type | Line | Description |
|---|---|---|
| TODO | 74 | od - condition is always true. can this be removed then? |
| Type | Line | Description |
|---|---|---|
| TODO | 189 | KV - check also saturday_delivery, late_buy, ECO |
| TODO | 209 | KV - clarify whether a separate request is really needed |
| TODO | 349 | ag: The old Position in redis has not $type property, remove this after a reasonable period. |
| Type | Line | Description |
|---|---|---|
| TODO | 649 | hw - this needs a better solution! |
| Type | Line | Description |
|---|---|---|
| TODO | 67 | check with eager loading! maybe better to move where condition to sql query |
| Type | Line | Description |
|---|---|---|
| TODO | 50 | ag: climate: may be move to repo. |
| Type | Line | Description |
|---|---|---|
| TODO | 297 | ag: seems to be dead method. Remove later. |
| Type | Line | Description |
|---|---|---|
| TODO | 143 | balances could be empty! check also with eager loading! |
| Type | Line | Description |
|---|---|---|
| TODO | 50 | DP remove party_id and check usage, vulnerability? |
| Type | Line | Description |
|---|---|---|
| TODO | 18 | better use getContactTypeIdByCode() to get contact type id! |
| Type | Line | Description |
|---|---|---|
| TODO | 19 | pl | Move to sd.sd_cm_user_identifier_token |
| Type | Line | Description |
|---|---|---|
| TODO | 41 | in UPA-9119 Concept comment, that it is not necessary for now - will be used in the future |
| Type | Line | Description |
|---|---|---|
| TODO | 525 | LE: How to deal with Pending and Received? Are these also used for card payments? Haven't found anything for this yet |
| Type | Line | Description |
|---|---|---|
| TODO | 322 | LE: maybe put together similar functions of other providers |
| Type | Line | Description |
|---|---|---|
| TODO | 21 | MB - UPDATE nötig! Funktionalitäten wie Variablen ersetzen fehlen |
| Type | Line | Description |
|---|---|---|
| TODO | 181 | mmueller UPA-8137 |
| Type | Line | Description |
|---|---|---|
| TODO | 117 | mbothstedt - Variants are currently not available. Is that still needed? |
| Type | Line | Description |
|---|---|---|
| TODO | 73 | // tgottschlich: When the Partnershops are finished, the following "where"-clause have to be excluded for those. |
| Type | Line | Description |
|---|---|---|
| TODO | 306 | RR UPA-8137 Step 3 |
| TODO | 320 | // When the Partnershops are finished, the following "where"-clause have to be excluded for those. |
| Type | Line | Description |
|---|---|---|
| TODO | 27 | mmueller UPA-8137 |
| TODO | 239 | mmueller UPA-8137 |
| TODO | 263 | mmueller UPA-8137 |
| TODO | 279 | mmueller UPA-8137 |
| TODO | 309 | mmueller UPA-8137 |
| TODO | 352 | mmueller UPA-8137 |
| Type | Line | Description |
|---|---|---|
| TODO | 72 | hw the function should return bool rather than int and should be modified to do so |
| TODO | 861 | ag: quick solution. Refactor later. Use composite selection. |
| Type | Line | Description |
|---|---|---|
| TODO | 27 | mmueller UPA-8137 |
| TODO | 72 | mmueller UPA-8137 |
| TODO | 101 | mmueller UPA-8137 |
| TODO | 128 | mmueller UPA-8137 |
| TODO | 161 | mmueller UPA-8137 |
| Type | Line | Description |
|---|---|---|
| TODO | 270 | UPA-11556: Adyen Step 2 |
| Type | Line | Description |
|---|---|---|
| TODO | 270 | RR UPA-8137 Step 5.2 |
| TODO | 347 | RR UPA-8137 Step 5.2 |
| TODO | 385 | RR UPA-8137 Step 5.2 |
| TODO | 457 | RR UPA-8137 Step 5.2 |
| TODO | 493 | RR UPA-8137 Step 5.2 |
| TODO | 645 | RR UPA-8137 Step 5.2 |
| TODO | 669 | RR UPA-8137 Step 5.2 |
| Type | Line | Description |
|---|---|---|
| TODO | 828 | Ausbau von db80050 user_account join entfernen |
| Type | Line | Description |
|---|---|---|
| TODO | 79 | all - this value should be migrated into the $addidionalData array |
| TODO | 166 | ag: maybe refactor later, move methods in service or trait PriceComponentsCalculator. |
| Type | Line | Description |
|---|---|---|
| TODO | 19 | Regina you changed this code and PendingOrderDataWriter, AddressHandlingLibrary and cetera was broken, please care about it. What i noticed you removed senderAddressId, maybe something else other was broken, check carefully all changing what did you. And after fix do not forget remove the line phpstan-ignore-next-line in function PendingOrderDataWriter -> setAddressIdsInParams, OrderLibrary -> prepareNewCustomerData and others ... i will notice you with TODO. Do not forget about testing |
| Type | Line | Description |
|---|---|---|
| TODO | 41 | KV - check whether clearance and clearance_date is needed |
| Type | Line | Description |
|---|---|---|
| TODO | 268 | DP uncomment with further implementation |
| TODO | 461 | ag: The old Position in redis has not $type property, remove this after a reasonable period. |
| TODO | 475 | ag: The old Position in redis has not $type property, remove this after a reasonable period. |
| TODO | 489 | ag: The old Position in redis has not $type property, remove this after a reasonable period. |
| TODO | 497 | ag: The old Position in redis has not $type property, remove this method after a reasonable period. |
| Type | Line | Description |
|---|---|---|
| TODO | 496 | (emakarov): where to g |
| Type | Line | Description |
|---|---|---|
| TODO | 90 | DP check by further implementation |
| Type | Line | Description |
|---|---|---|
| TODO | 183 | $mockupPath is static for copy paper. This should need to store in a proper way. |